impact guides with no CSV fixture support #499

Merged
merged 1 commit into from May 10, 2011

Conversation

Projects
None yet
3 participants
@smartinez87
Contributor

smartinez87 commented May 10, 2011

Impact guides with this change: 558334a

josevalim added a commit that referenced this pull request May 10, 2011

Merge pull request #499 from smartinez87/csv
impact guides with no CSV fixture support

@josevalim josevalim merged commit 7b6819f into rails:master May 10, 2011

@asanghi

This comment has been minimized.

Show comment Hide comment
@asanghi

asanghi May 10, 2011

Contributor

Perhaps I'm mistaken (/cc @fxn ) but are we still committing documentation changes to https://github.com/lifo/docrails and then they get pulled into rails core or are we now short-circuiting that process? Just want to know if the process has changed?

Contributor

asanghi commented May 10, 2011

Perhaps I'm mistaken (/cc @fxn ) but are we still committing documentation changes to https://github.com/lifo/docrails and then they get pulled into rails core or are we now short-circuiting that process? Just want to know if the process has changed?

@josevalim

This comment has been minimized.

Show comment Hide comment
@josevalim

josevalim May 10, 2011

Contributor

I believe it is because those changes are not in docrails yet. But you have a point, i should leave those pull requests for @fxn to apply.

Contributor

josevalim commented May 10, 2011

I believe it is because those changes are not in docrails yet. But you have a point, i should leave those pull requests for @fxn to apply.

hisas pushed a commit to hisas/rails that referenced this pull request May 9, 2017

hisas pushed a commit to hisas/rails that referenced this pull request May 9, 2017

matthewd pushed a commit that referenced this pull request Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment