Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upassigns(:foo) should not convert @foo's keys to strings if it happens to be a hash #5082
+7
−1
Conversation
tenderlove
added a commit
that referenced
this pull request
Feb 20, 2012
…_values_master assigns(:foo) should not convert @foo's keys to strings if it happens to be a hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is an unintended side effect of the code to make assigns(:foo) work the same way as assigns('foo').
This pull request is relative to master, but the same bug and fix apply to all 3.x versions -
3.2: https://github.com/willbryant/rails/tree/assigns_should_not_stringify_values_3-2-stable
3.1: https://github.com/willbryant/rails/tree/assigns_should_not_stringify_values_3-1-stable
3.0: https://github.com/willbryant/rails/tree/assigns_should_not_stringify_values