Remove reference to config.action_view.logger from Rails configuration guide #5087

merged 1 commit into from Feb 22, 2012


None yet
4 participants

pwnall commented Feb 19, 2012

This is a doc patch, but I'm sending a full pull request because I'm not 100% sure of it.

I tried using this configuration setting in my application, and got

actionpack-3.2.1/lib/action_view/railtie.rb:34:in `block (3 levels) in <class:Railtie>': undefined method `logger=' for ActionView::Base:Class (NoMethodError)

I looked in rails/action_pack/lib/action_view/base.rb and it seems that logger is delegated to ActionController::Base (line 151). Last but not least, ActionView::LogSubscriber.logger uses ActionController::Base.logger directly, with a TODO saying that ActionView needs a logger.

Last but not least, this pull is for 3-2-stable, just in case you might like to add the logger option in Rails 4. I'll be happy to send another pull request for master, if it's desired.


arunagw commented Feb 22, 2012

cc/ @vijaydev


rafaelfranca commented Feb 22, 2012

Yeah. This documentation is wrong. But the in the master branch this options exists, as you can see here 5a6ea53

👍 for this pull request

@tenderlove tenderlove added a commit that referenced this pull request Feb 22, 2012

@tenderlove tenderlove Merge pull request #5087 from pwnall/no_view_logger
Remove reference to config.action_view.logger from Rails configuration guide

@tenderlove tenderlove merged commit c5c3274 into rails:3-2-stable Feb 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment