Binary mode window bug #5179

Merged
merged 1 commit into from Feb 27, 2012

Conversation

Projects
None yet
2 participants

In asset_tag_helper_test.rb there is an assert on the number of bytes in a
concatenated file. This test failed because Windows converts \n to \r\n as
the default for "w". This is different than in *nix systems where there is
no conversion done.

The test that failed was test_caching_stylesheet_link_tag_when_caching_on

Using bin mode fixes this behavior on windows and makes no change on the
*nix systems.

Fixing Windows asset tag helper test failure
In asset_tag_helper_test.rb there is an assert on the number of bytes in a
concatenated file.  This test failed because Windows converts \n to \r\n as
the default for "w".  This is different than in *nix systems where there is
no conversion done.

THe test that failed was test_caching_stylesheet_link_tag_when_caching_on

Using bin mode fixes this behavior on windows and makes no change on the
*nix systems.

tenderlove added a commit that referenced this pull request Feb 27, 2012

@tenderlove tenderlove merged commit b543f8f into rails:3-2-stable Feb 27, 2012

tenderlove added a commit that referenced this pull request Feb 27, 2012

tenderlove added a commit that referenced this pull request Feb 27, 2012

@42he 42he referenced this pull request Sep 9, 2013

Closed

Reintroduced Bug #5179 #12179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment