Maximum wait_timeout on Windows is 2147483 #5244

Merged
merged 1 commit into from May 25, 2012

Conversation

Projects
None yet
3 participants
Contributor

fotos commented Mar 2, 2012

As documented on MySQL's site [1] this is the maximum value for Windows. We should use the least common denominator. Also done in the old branch (0.2.x) of mysql2 gem [2] and [3].

[1] http://dev.mysql.com/doc/refman/5.0/en/server-system-variables.html#sysvar_wait_timeout
[2] https://github.com/brianmario/mysql2/blob/0.2.x/lib/active_record/connection_adapters/mysql2_adapter.rb#L577
[3] brianmario/mysql2@4f4909f

rafaelfranca added a commit that referenced this pull request May 25, 2012

Merge pull request #5244 from fotos/myqsl2_wait_timeout
Maximum wait_timeout on Windows is 2147483

rafaelfranca added a commit that referenced this pull request May 25, 2012

Merge pull request #5244 from fotos/myqsl2_wait_timeout
Maximum wait_timeout on Windows is 2147483

@rafaelfranca rafaelfranca merged commit a2bf014 into rails:master May 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment