Default scope breaks working of has_many :through #528

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@wakeless

Adding a default_scope to the end of a has_many :through relationship breaks a number of things.

I've found it through a :uniq => true on the relationship, but the attached change to the tests seems to break a number of other things

@josevalim

This comment has been minimized.

Show comment Hide comment
@josevalim

josevalim May 12, 2011

Contributor

Is this a regression? Does this work on 3.0?

Contributor

josevalim commented May 12, 2011

Is this a regression? Does this work on 3.0?

@josevalim

This comment has been minimized.

Show comment Hide comment
@josevalim

josevalim May 12, 2011

Contributor

How is this different from #508?

Contributor

josevalim commented May 12, 2011

How is this different from #508?

@ghost ghost assigned jonleighton May 12, 2011

@jonleighton

This comment has been minimized.

Show comment Hide comment
@jonleighton

jonleighton May 12, 2011

Member

I am closing this in favour of an issue which I just created (#533) because we are definitely not going to merge this in its present form so we should discuss the bug in an issue. Thanks.

Member

jonleighton commented May 12, 2011

I am closing this in favour of an issue which I just created (#533) because we are definitely not going to merge this in its present form so we should discuss the bug in an issue. Thanks.

jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment