Fix issue 5193 #5398

Merged
merged 2 commits into from Mar 13, 2012

Conversation

Projects
None yet
3 participants
Contributor

parndt commented Mar 13, 2012

Proposal to fix issue #5193

Feedback welcome; thanks!

Contributor

kennyj commented Mar 13, 2012

I also tackled an original issue (two / three days before).

First, I made a testcase for the issue.
But I realized if the issue is fixed we have more bigger problem ;-)
Ex.

  • I guess that a testcase for plugin_new has some potentially problem (ex bundle install is failure)
  • we must execute rake db:migrate with RAILS_ENV=test
  • sometimes I saw table don't exists ...

I'm thinking a solution of above problems :)

p.s. I think that this PR is work fine :-)

josevalim added a commit that referenced this pull request Mar 13, 2012

@josevalim josevalim merged commit d2ac18a into rails:3-2-stable Mar 13, 2012

Contributor

josevalim commented Mar 13, 2012

Could you also send a PR for master? Thanks.

Contributor

parndt commented Mar 13, 2012

@josevalim sure, will do that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment