Address the dump file format for hstore #5451

Merged
merged 1 commit into from Mar 15, 2012

Projects

None yet

2 participants

@yahonda
Contributor
yahonda commented Mar 15, 2012

When ActiveRecord unit tests are tested with PostgreSQL v9.1.2(hstore installed),
Always got a failure as follows.

$ ARCONN=postgresql ruby -Itest test/cases/schema_dumper_test.rb -n 'test_schema_dump_includes_hstores_shorthand_definition'
Using postgresql
Run options: -n test_schema_dump_includes_hstores_shorthand_definition --seed 31050

# Running tests:

F

Finished tests in 1.178730s, 0.8484 tests/s, 1.6967 assertions/s.

  1) Failure:
test_schema_dump_includes_hstores_shorthand_definition(SchemaDumperTest) [test/cases/schema_dumper_test.rb:242]:
Expected /t.hstore "hash_store", default => ""/ to match "# ... snip ...

The dump file output is slightly different from current test code.
You can see the whole (very long) output via https://gist.github.com/1b0444910e7d6ad5b404

@tenderlove tenderlove merged commit 94a20d9 into rails:master Mar 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment