Fix build for branch 3-2-stable #5557

Merged
merged 1 commit into from Mar 23, 2012

Projects

None yet

2 participants

@carlosantoniodasilva
Ruby on Rails member

These changes should fix the build for 3-2-stable branch.

The failures are happening due to the change from 1.8.7-p352 to 1.8.7-p358. It includes a change on Hash implementation, making fixtures to be loaded randomly, thus making tests without explicit ordering fail.

After talking to @tenderlove, we decided to skip persistence tests related to UPDATE + ORDER BY for PostgreSQL (there are three). PG does not support updates with order by, and a test is failing randomly depending on the fixture loading order now without a proper way to fix (a possibility would be to force all fixtures to use omap, but the test doesn't make that much sense to run under pg anyway - more ideas are welcome).

I've run both test_postgresql and isolated_test_postgresql rake tasks several times locally to make sure no other test was failing randomly, however I can't ensure some test won't fail in a near future that my runs didn't catch.

I have also fixes for 3-1 and 3-0 branches, just want to discuss this PR and if applied, make sure it runs green on travis before sending the others.

Let me know if something should be improved.

/cc @nzkoz @spastorino

@carlosantoniodasilva carlosantoniodasilva Add order to tests that rely on db ordering, to fix failing tests on pg
Also skip persistente tests related to UPDATE + ORDER BY for postgresql

PostgreSQL does not support updates with order by, and these tests are
failing randomly depending on the fixture loading order now.
b332891
@tenderlove tenderlove merged commit ea4e021 into rails:3-2-stable Mar 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment