Allow a defining custom member field on resources #5581
Conversation
By default, resources routes are created with :resource/:id. A model defining to_param can make prettier urls by using something more readable than an integer ID, but since the route picks it up as :id you wind up with awkward User.find_by_username(params[:id]) calls. By overriding the key to be used in @request.params you can be more obvious in your intent.
Allow a defining custom member field on resources
|
Just realized I was working on a dupe of this issue (see #7116). Can I do a backport to rails 3.2 and add some docs? |
The Mapper looks for a :id constraint in the scope to see whether it should apply a constraint for nested resources. Since #5581 added support for resource params other than :id, we need to check for a constraint on the parent resource's param name and not assume it's :id.
Since #5581 added support for resources with custom params we should not assume that it is :id when using shallow resource routing.
|
@TildeWill I don't think we should backport this since it is adding feature. 3-2-stable is only to bug fixes now. |
|
Just a note that a custom resource param is going to fail with passing a hash to |
|
But if I want to use both patterns - access resource by |
|
@kuraga the best solution for that is to use a url slug library like FriendlyId which overrides |
|
@pixeltrix thanks! @jamie @pixeltrix But I want to say that maybe it's a thin moment... If we right resources :products, :only => :show
resources :products, :param => :slug, :only => :showwe get scope '/products' do
controller 'products' do
get '/:id/edit', :action => 'edit', :as => :edit_product
end
end
scope '/products' do
controller 'products' do
get '/:slug/edit', :action => 'edit', :as => :edit_product
end
endAm I right? If yes we get to |
|
@kuraga the problem is that |
|
@pixeltrix Thank you! And i think that's a problem of this patch! If it's wrong to write two |
|
@kuraga Why do you need two routes for Products#show? That's redundant. Pick one as the canonical URL scheme and stick with it. |
Option discovered by @zackperdue in rails#14741, implemented in rails#5581.
Option discovered by @zackperdue in rails#14741, implemented in rails#5581.
Option discovered by @zackperdue in #14741, implemented in #5581.
* master: Update url to rake docs [ci skip] Name#model_name doesn't return a String object Result sets never override a model's column type [ci skip] Make last note show up in postgresql guide. Add missing `:param` option from the docs for Mapper#match [ci skip] Option discovered by @zackperdue in #14741, implemented in #5581. Add @senny's changed from #14741, including code font for `resources` options, and wrapped to 80 chars. [ci skip] Use github url for homepage of log4r [ci skip] Remove TODO. Ensure we always use instances of the adapter specific column class Fix indentation from 1b4b26f [ci skip] [ci skip] Improve form_helpers.md guide. Clear inflections after test. Remove unnecessary include for integration tests. Added documentation for the :param option for resourceful routing
By default, resources routes are created with :resource/:id. A model
defining to_param can make prettier urls by using something more
readable than an integer ID when generating URLs, but since the route picks it up as :id you
wind up with awkward User.find_by_username(params[:id]) calls.
By overriding the key to be used in @request.params you can be more
obvious in your intent.
This override is basically as simple as it needs to be, just an extra :param
option on the resource(s) definition on the route. There's no work done to force
the url generators to use that field when passed a model, but since to_param
is already overridable I don't think it's necessary.
Patch includes tests for a plain resource as well as a nested resource
(generating user_login for the above example).