New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveModel::Name does not inherit from string #5593
ActiveModel::Name does not inherit from string #5593
Conversation
…on_over_inheritance ActiveModel::Name does not inherit from string
|
It made it for convenience, because it may be common to compare model name with a String. And without |
|
Where should I send the $100? |
|
Just for comparison, I was racing with this: steveklabnik@8f6a4b8 |
|
@steveklabnik @lukesarnacki this is what I had jmazzi@0d85690. @lukesarnacki removed the failing test I was trying to fix. |
|
@jmazzi I changed only test that asserts ActiveModel::Naming is a String. Not removed anything. |
|
I wasn't trying to imply the change you made was wrong. It was the proper change. I should have done the same. |
|
@jmazzi :) |
|
@steveklabnik @lukesarnacki @jmazzi here is my approach: rkh@d8ced12 |
|
class Rkh < |
|
Yet another reason I wish that |
|
@tenderlove open an emergency feature request ticket for Ruby 2.0 |
|
@tenderlove U+1F479 and U+1F47A come pretty close. |
Like in ActiveModel::Errors we should favor composition over inheritance