Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixing issue #2492 for master branch #5615

Merged
merged 1 commit into from Mar 27, 2012

Conversation

Projects
None yet
3 participants
Contributor

kryzhovnik commented Mar 27, 2012

ActionView::Base.field_error_proc doesn't call for label.

objectify_options method should be applied to the proper options arg.

See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example

@kryzhovnik kryzhovnik Fixing issue #2492 for master branch. ActionView::Base.field_error_pr…
…oc doesn't call for label.

objectify_options method should be applied to the proper options arg.

See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example
6ce0a6d
Owner

rafaelfranca commented Mar 27, 2012

I don't think this is the best way to solve this issue, and I don't think that this is a issue too. Is there some case where the error_proc is used with label?

Owner

rafaelfranca commented Mar 27, 2012

I saw that in a sccafolded view it works. But I still think that this is not the best way to solve it. This is duplicating this logic: https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/tags/label.rb#L6-12

@rafaelfranca rafaelfranca added a commit to rafaelfranca/omg-rails that referenced this pull request Mar 27, 2012

@rafaelfranca rafaelfranca Check if the options hash already exists and merge it with the another
hash.

Closes #2492 and #5615
32763a8

@jeremy jeremy merged commit 6ce0a6d into rails:master Mar 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment