Fixing Identity Map when using find select #5647

Merged
merged 4 commits into from Mar 29, 2012
Commits on Mar 28, 2012
  1. Do not add record to identity map if the record doesn't have values f…

    arturopie committed Mar 26, 2012
    …or all the columns, so we don't get 'MissingAttributeError' later when trying to access other fields of the same record.
  2. refactor the checking of the attributes of the record in IdentityMap#…

    arturopie committed Mar 27, 2012
    …add, so it's more readable
Commits on Mar 29, 2012
  1. refactor instantiate method in base, so we remove nesting if's which …

    arturopie committed Mar 27, 2012
    …make the code harder to read. Minor changes to contain_all_columns in IdentityMap.