Issue 4083 #5686

Merged
merged 2 commits into from Apr 3, 2012

Projects

None yet

3 participants

@arunagw
Member
arunagw commented Mar 31, 2012

allowing for subdomain(s) removal from the host during link generation.

Closes #4083

cherry-picked from

de942e5
96aa3bd

arunagw added some commits Mar 31, 2012
@arunagw arunagw :subdomain can now be specified with a value of false in url_for,
allowing for subdomain(s) removal from the host during link generation. 

Closes #4083

cherry-picked from 

de942e5
96aa3bd
54d3645
@arunagw arunagw CHANGELOG entry added c409d06
@arunagw
Member
arunagw commented Apr 3, 2012
@arunagw
Member
arunagw commented Apr 3, 2012

I am not sure we need to backport this in 3-1-stable. As this is already in 3-2-stable and master.

in #4083 it asked to be backport to 3-1

@josevalim josevalim merged commit 8c3ca29 into rails:3-1-stable Apr 3, 2012
@ognevsky
ognevsky commented Mar 9, 2013

Why can't we use nil and "" among the false option to reset current subdomain?
It's more obvious that subdomain: nil, subdomain: false, and subdomain: '' do the same, here is no reason (as for me) to use only one way. What do you think?

/cc @josevalim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment