Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix scope leaking #5762

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

keymone commented Apr 6, 2012

don't know if rails 2.3 is still accepting such fixes but this one is pretty annoying for me and fix is really simple

problem is that Proc#bind is called every time scope has to change it's execution context and that happens often when one uses STI

Proc#bind was recently deprecated from rails/master and replaced with same solution i got for my problem here

Member

arunagw commented Apr 7, 2012

I think 2-3-stable is only accepting major security fixes.

cc/ @josevalim

Member

drogus commented Apr 7, 2012

@arunagw we don't prommise to provide anything more than major security fixes, but that does not mean that if someone has a patch, we can't merge it

Member

arunagw commented Apr 18, 2012

Can we review this then ??

cc/ @drogus @jeremy

Owner

rafaelfranca commented Apr 29, 2012

This is ok for me. But as we are not supporting 2.3.x, what will we do if this patch add more issues?

Contributor

josevalim commented Apr 29, 2012

We no longer maintain 2.3. At this point it is even unlikely that it will get a security fix.

@josevalim josevalim closed this Apr 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment