Skip to content

Fix ORA-00972 error at test_rename_table_with_prefix_and_suffix #5837

Merged
merged 1 commit into from Apr 14, 2012

3 participants

@yahonda
yahonda commented Apr 13, 2012

This pull request addresses the following ORA-00972 error because Oracle supports 30 byte maximum sequence name length.

$ ARCONN=oracle ruby -Itest test/cases/migration_test.rb -n 'test_rename_table_with_prefix_and_suffix'
Using oracle
Run options: -n test_rename_table_with_prefix_and_suffix --seed 55032

# Running tests:

... snip ...
E

Finished tests in 0.979560s, 1.0209 tests/s, 3.0626 assertions/s.

  1) Error:
test_rename_table_with_prefix_and_suffix(MigrationTest):
ArgumentError: New sequence name 'prefix_awesome_things_suffix_seq' is too long; the limit is 30 characters
    /home/yahonda/Dropbox/git/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb:105:in `rename_table'
    /home/yahonda/Dropbox/git/rails/activerecord/lib/active_record/migration.rb:467:in `block in method_missing'
    /home/yahonda/Dropbox/git/rails/activerecord/lib/active_record/migration.rb:439:in `block in say_with_time'

1 tests, 3 assertions, 0 failures, 1 errors, 0 skips

It was originally reported at #4190 and was closed because Oracle oracle enhanced adapter did not work with rails master branch for a while.

Recently, Oracle oracle enhanced adapter is working with the rails master branch and found this error still exists.

This pull request has been tested with postgresql, mysql, mysql2 and sqlite3 adapters.

@jonleighton jonleighton merged commit d1f4cda into rails:master Apr 14, 2012
@arunagw
Ruby on Rails member
arunagw commented Apr 14, 2012

thanks @yahonda :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.