Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Incorporating Pacific Island zone changes circa Dec 31 2011 #5838

Merged
merged 1 commit into from

3 participants

@IamNaN

Correcting some confusion. The Pacific/Pago_Pago zone should have been labeled "American Samoa" not "Samoa". They're 75 miles apart but different.

It's especially important because at the end of 2011 Samoa (and also Tokelau) jumped across the international dateline to be on the same day as New Zealand and Australia. They switched to UTC+13 and left American Samoa at UTC-11.

Documentation about the dateline change is at IANA in the file 'austalasia'.

Pacific/Fakaofo and Pacific/Apia are in TZInfo and present in ruby 1.9.3. Perhaps this is a Rails 4.0 tweak.

@IamNaN IamNaN Correcting some confusion. Pago Pago is part of American Samoa, not S…
…amoa. Further, Samoa and Tokelau jumped across the IDL from Dec 29 to Dec 31, 2011 switching from UTC-11 to UTC+13. American Samoa did not make the change and remains at UTC-11. Pacific/Fakaofo and Pacific/Apia are in TZInfo and documentation about the dateline change is in austalasia at IANA.
1d08ce5
@carlosantoniodasilva

Sounds ok to me. Not sure if we need some tests. @pixeltrix can you take a quick look please?

@pixeltrix pixeltrix merged commit 63c00ba into rails:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 13, 2012
  1. @IamNaN

    Correcting some confusion. Pago Pago is part of American Samoa, not S…

    IamNaN authored
    …amoa. Further, Samoa and Tokelau jumped across the IDL from Dec 29 to Dec 31, 2011 switching from UTC-11 to UTC+13. American Samoa did not make the change and remains at UTC-11. Pacific/Fakaofo and Pacific/Apia are in TZInfo and documentation about the dateline change is in austalasia at IANA.
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 2 deletions.
  1. +4 −2 activesupport/lib/active_support/values/time_zone.rb
View
6 activesupport/lib/active_support/values/time_zone.rb
@@ -28,7 +28,7 @@ class TimeZone
MAPPING = {
"International Date Line West" => "Pacific/Midway",
"Midway Island" => "Pacific/Midway",
- "Samoa" => "Pacific/Pago_Pago",
+ "American Samoa" => "Pacific/Pago_Pago",
"Hawaii" => "Pacific/Honolulu",
"Alaska" => "America/Juneau",
"Pacific Time (US & Canada)" => "America/Los_Angeles",
@@ -167,7 +167,9 @@ class TimeZone
"Marshall Is." => "Pacific/Majuro",
"Auckland" => "Pacific/Auckland",
"Wellington" => "Pacific/Auckland",
- "Nuku'alofa" => "Pacific/Tongatapu"
+ "Nuku'alofa" => "Pacific/Tongatapu",
+ "Tokelau Is." => "Pacific/Fakaofo",
+ "Samoa" => "Pacific/Apia"
}
UTC_OFFSET_WITH_COLON = '%s%02d:%02d'
Something went wrong with that request. Please try again.