Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Changes b tag to strong #5869

Merged
merged 1 commit into from

2 participants

@LachyGroom

The change is made due to importance of the attribute name (e.g. Name:) on the page (versus just stylistic / appearance sake tag).

@LachyGroom LachyGroom Changes b tag to strong

The change is made due to importance of the attribute name (e.g. Name:) on the page (versus just stylistic / appearance sake tag).
b9b9bd8
@drogus
Collaborator

Actually, b makes more sense here. One of the explanations is here: http://html5doctor.com/i-b-em-strong-element/

The strong element represents strong importance for its contents.
HTML — Living Standard, WHATWG

Not much more to say really — it’s the <strong> we all know so well. Indicate relative importance by nesting <strong> elements, and use <em> for text with stress emphasis, or <b> for text that is “stylistically offset” or bold without being more important.

@LachyGroom

From the same page "Only use <b> when there are no other more suitable elements — e.g., <strong> for text with semantic importance", <b> would be more appropriate if it was the first letter of a book, for typographical reasons.

@drogus
Collaborator

Ok, so it depends if you look at those elements as just styling or elements with greater semantical importance. After rethinking that I agree with you. Those attribute names are more important than values and you may want to style them differently than using bold.

@drogus drogus merged commit e9f778a into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 17, 2012
  1. @LachyGroom

    Changes b tag to strong

    LachyGroom authored
    
    The change is made due to importance of the attribute name (e.g. Name:) on the page (versus just stylistic / appearance sake tag).
This page is out of date. Refresh to see the latest.
View
2  railties/lib/rails/generators/erb/scaffold/templates/show.html.erb
@@ -2,7 +2,7 @@
<% attributes.each do |attribute| -%>
<p>
- <b><%= attribute.human_name %>:</b>
+ <strong><%= attribute.human_name %>:</strong>
<%%= @<%= singular_table_name %>.<%= attribute.name %> %>
</p>
Something went wrong with that request. Please try again.