Added option to pass block to link_to_function #5886

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@Ninju

Ninju commented Apr 18, 2012

Patch to solve issue here: #3093

Allows you to pass a block to link_to_function (similar to link_to) if the link text is too complex to be passed as a string argument.

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Apr 18, 2012

Member

With unobtrusive javascript still we need link_to_function? I think we can deprecate it in 4.0 and remove in 4.1.

What do you thing @jeremy, @drogus?

Member

rafaelfranca commented Apr 18, 2012

With unobtrusive javascript still we need link_to_function? I think we can deprecate it in 4.0 and remove in 4.1.

What do you thing @jeremy, @drogus?

@guilleiguaran

This comment has been minimized.

Show comment Hide comment
@guilleiguaran

guilleiguaran Apr 18, 2012

Member

or... extract to plugin and remove in 4.0 :)

Member

guilleiguaran commented Apr 18, 2012

or... extract to plugin and remove in 4.0 :)

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Apr 18, 2012

Member

better option 👍

Member

rafaelfranca commented Apr 18, 2012

better option 👍

@jeremy

This comment has been minimized.

Show comment Hide comment
@jeremy

jeremy Apr 30, 2012

Member

link_to_function is removed in 4.0, so closing this rather than add to 3-2-stable.

Member

jeremy commented Apr 30, 2012

link_to_function is removed in 4.0, so closing this rather than add to 3-2-stable.

@jeremy jeremy closed this Apr 30, 2012

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Apr 30, 2012

Member

@jeremy I merged this commit in my pull request xD

Member

rafaelfranca commented Apr 30, 2012

@jeremy I merged this commit in my pull request xD

rafaelfranca added a commit to rafaelfranca/omg-rails that referenced this pull request Apr 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment