Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Revert #5861 #5896

Merged
merged 2 commits into from Apr 21, 2012

Conversation

Projects
None yet
4 participants
Contributor

sferik commented Apr 19, 2012

This reverts commit 9b14e3f.

Rationale: #5861 (comment)

Owner

jeremy commented Apr 19, 2012

We need to feature-detect and prefer the new API rather than show deprecation warnings our users can't do anything about. The warnings are for us, users of the multi_json lib, not everyone who invokes a Rails 3.2 command and wonders why it's squawking at them.

Good call!

Contributor

laserlemon commented Apr 21, 2012

👍

Owner

jeremy commented Apr 21, 2012

Thanks @sferik!

@jeremy jeremy added a commit that referenced this pull request Apr 21, 2012

@jeremy jeremy Merge pull request #5896 from sferik/revert_5861
Revert #5861. Feature-detect which MultiJson API to use.
c3d50b3

@jeremy jeremy merged commit c3d50b3 into rails:3-2-stable Apr 21, 2012

@AlexRiedler AlexRiedler pushed a commit to AlexRiedler/rails that referenced this pull request Jan 9, 2013

@jeremy jeremy + Alex Riedler Merge pull request #5896 from sferik/revert_5861
Revert #5861. Feature-detect which MultiJson API to use.
Conflicts:
	activesupport/activesupport.gemspec

This backports multi_json version depedency changes as applied.

Rationale: #5861

Patch by sferik
7b9bab6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment