Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Quote arguments in db:structure:dump for PostgreSQL. #5925

Merged
merged 1 commit into from May 24, 2012

Conversation

Projects
None yet
3 participants
Contributor

Juanmcuello commented Apr 21, 2012

This patch quotes the arguments when calling pg_dump in db:structure:dump, otherwise the task fails when there are spaces.

fixes #5913

Owner

tenderlove commented May 23, 2012

Can you convert this to use Shellwords.escape? It should deal with spaces and more.

Contributor

Juanmcuello commented May 23, 2012

Done. Squashed and rebased.

@carlosantoniodasilva carlosantoniodasilva added a commit that referenced this pull request May 24, 2012

@carlosantoniodasilva carlosantoniodasilva Merge pull request #5925 from Juanmcuello/pg_structure_dump
Quote arguments in db:structure:dump for PostgreSQL.
a9af9f1

@carlosantoniodasilva carlosantoniodasilva merged commit a9af9f1 into rails:3-2-stable May 24, 2012

@carlosantoniodasilva carlosantoniodasilva added a commit that referenced this pull request May 24, 2012

@carlosantoniodasilva carlosantoniodasilva Merge pull request #5925 from Juanmcuello/pg_structure_dump
Quote arguments in db:structure:dump for PostgreSQL.
6775ad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment