Break support mysql adapter #6030

Closed
wants to merge 2 commits into
from

Projects

None yet
@aderyabin

In continue of break support antiquity I suggest to break support mysql adapter (to use only mysql2).

Really, what is reason to have 2 adapters for one DBMS? mysql gem doesn't support EXPLAIN. It's really funny and sad.

@jeremy
Member
jeremy commented Apr 28, 2012

👍

Would be a good idea to extract as a activerecord-mysql-adapter gem for folks who want to continue using it (for whatever reason)

@josevalim
Member

I am José Valim and I approve this message.

@larzconwell

👍 I like this idea, I saw this earlier and thought it was weird to keep it.

@drogus
Member
drogus commented Apr 28, 2012

@jeremy I would assume that no one will be using it in 4.0 ;) If that's not the case someone can still extract it based on that commit, but I would not wait with merging this.

@rafaelfranca
Member

Remember that mysql2 doesn't work very well on Windows.

@drogus
Member
drogus commented Apr 29, 2012

@rafaelfranca bummer, I didn't know that.

@erichmenge

@aderyabin I was thinking about doing the same thing. @carlosantoniodasilva pointed me to this PR. Were you planning on extracting the mysql adapter out into a gem?

@guilleiguaran
Member

is possible get mysql2 gem working fine under Windows?

I have a project running under a Windows machine using mysql2 and is working without any problems, I'm using Ruby 1.9.3 and Rails 3.2 (installed both with RailsInstaller)

cc @luislavena

Edit:
http://github.com/brianmario/mysql2/issues#issue/8
http://paul-wong-jr.blogspot.com/2011/06/getting-mysql2-gem-to-work-with-ruby-on.html
http://rorguide.blogspot.com/2011/03/installing-mysql2-gem-on-ruby-192-and.html

@aderyabin

Yes. I'm in progress.

@erichmenge

👍

@luislavena

I haven't played with mysql2 in long time, but it had issues on Windows (like blocking operations) that made really hard get some stuff done.

This was caused by the way Ruby 1.8 differs from Ruby 1.9: changes to make Ruby 1.9 work broke Ruby 1.8 functionality.

If mysql2 works on a version that is only 1.9.x (lets say 0.4 or something) then I think things could work.

I still need to test it out.

@frodsan
frodsan commented Oct 29, 2012

@aderyabin any news? Could you rebase this?

@rafaelfranca
Member

@aderyabin are you still interessed to work on this pull request? I think if extract it to a adapter like @jeremy pointed we don't need to worry about Windows failures.

@rafaelfranca rafaelfranca was assigned Nov 21, 2012
@aderyabin

I''ll end work on this pull request this week.

@rafaelfranca
Member

Awesome!! I look forward to see this merged before Rails 4.0

@aderyabin

@rafaelfranca I finished work. Please review and merge.

@steveklabnik
Member

Doesn't merge cleanly.

@rafaelfranca
Member

@aderyabin we need to review/move the tests under activerecord/test/cases/adapters/mysql to the gem

@tenderlove
Member

So, I'm kind of 👎 on this pull request. One, I know that folks at twitter use Rails 3.2.x with mysql (and won't use mysql2). So there are > 0 users of the mysql adapter. The second reason is that it's likely that I'll end up maintaining the adapter, and it's just easier for me to maintain it while it's in core.

If this is just to break it out of core, but no maintainer is volunteering, then 👎. To casual observers, it may seem strange that we ship to mysql adapters, but I know for a fact that people use both mysql and mysql2. Which means this becomes a question of "who will maintain the adapter?".

Currently the answer is @tenderlove. If the answer is to remain @tenderlove, then we should not remove this from core.

@rafaelfranca
Member

It is a good reason. I'll close this pull request. If anyone want to take the project we can reopen.

@aderyabin thank you so much for the pull request.

@aderyabin

@tenderlove. It's very strange. Why folks at Twitter can move to rails4 and can't to mysql2? Moving from rails 2 to rails 3 had more troubles than from mysql to mysql2.

@tenderlove
Member

@aderyabin AFAIK, it's because they maintain a fork of the mysql gem. But I'm not 100% certain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment