Remove ActiveSupport 1.8 backports #6066

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@larzconwell
Contributor

I believe this removes 1.8 support, I'm not sure what else I need to remove or update so let me know please!

/cc @fxn

@rafaelfranca
Member

This pull request cannot be automatically merged.

@larzconwell
Contributor

What?

@rafaelfranca
Member

This is what Github is telling me.

@larzconwell
Contributor

Don't merge it, I wan't more people from Rails core to see what needs to be changed since it is a huge part of 4.0.0.

@jeremy
Member
jeremy commented Apr 29, 2012

How about removing the actual backported feature support as well?

@larzconwell
Contributor

I thought about that, except other applications that are using ActiveSupport might be using those core extensions, so I decided not too.

Also in IRB(Ruby 1.9.3-p194) I tested out all those core extensions without ActiveSupport and none were defined so it seems like they're still needed anyway. Maybe I have no clue what I'm doing though (;

@steveklabnik
Member

@larzconwell what 'cant be merged' means is that even if they deem the change good, it can't be used until you rebase the commits off of master.

@rafaelfranca
Member

@steveklabnik, @spastorino removed this file at a638104. I'm closing this one.

Thanks @larzconwell.

@larzconwell
Contributor

Yeah I figured that out a few days ago @steveklabnik, thanks though (:

@steveklabnik
Member

Word. My bad for not noticing. :)

@larzconwell
Contributor

Thanks @rafaelfranca for closing! I totally forgot about this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment