Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove ActiveSupport 1.8 backports #6066

Closed
wants to merge 1 commit into from

4 participants

@larzconwell

I believe this removes 1.8 support, I'm not sure what else I need to remove or update so let me know please!

/cc @fxn

@rafaelfranca

This pull request cannot be automatically merged.

@larzconwell

What?

@rafaelfranca

This is what Github is telling me.

@larzconwell

Don't merge it, I wan't more people from Rails core to see what needs to be changed since it is a huge part of 4.0.0.

@jeremy
Owner

How about removing the actual backported feature support as well?

@larzconwell

I thought about that, except other applications that are using ActiveSupport might be using those core extensions, so I decided not too.

Also in IRB(Ruby 1.9.3-p194) I tested out all those core extensions without ActiveSupport and none were defined so it seems like they're still needed anyway. Maybe I have no clue what I'm doing though (;

@steveklabnik
Collaborator

@larzconwell what 'cant be merged' means is that even if they deem the change good, it can't be used until you rebase the commits off of master.

@rafaelfranca

@steveklabnik, @spastorino removed this file at a638104. I'm closing this one.

Thanks @larzconwell.

@larzconwell

Yeah I figured that out a few days ago @steveklabnik, thanks though (:

@steveklabnik
Collaborator

Word. My bad for not noticing. :)

@larzconwell

Thanks @rafaelfranca for closing! I totally forgot about this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 29, 2012
  1. @larzconwell
This page is out of date. Refresh to see the latest.
View
1  actionpack/lib/abstract_controller.rb
@@ -3,7 +3,6 @@
require 'action_pack'
require 'active_support/concern'
-require 'active_support/ruby/shim'
require 'active_support/dependencies/autoload'
require 'active_support/core_ext/class/attribute'
require 'active_support/core_ext/module/attr_internal'
View
1  actionpack/lib/action_view.rb
@@ -21,7 +21,6 @@
# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
#++
-require 'active_support/ruby/shim'
require 'active_support/core_ext/class/attribute_accessors'
require 'action_pack'
View
2  activesupport/CHANGELOG.md
@@ -1,5 +1,7 @@
## Rails 4.0.0 (unreleased) ##
+* Remove ActiveSupport Ruby 1.8 backports, we're only support 1.9+ from now on *Larz Conwell*
+
* Add ActiveSupport::Deprecations.behavior = :slience to to completely ignore *twinturbo*
* Make Module#delegate stop using `send` - can no longer delegate to private methods. *dasch*
View
15 activesupport/lib/active_support/ruby/shim.rb
@@ -1,15 +0,0 @@
-# Backported Ruby builtins so you can code with the latest & greatest
-# but still run on any Ruby 1.8.x.
-#
-# Date next_year, next_month
-# DateTime to_date, to_datetime, xmlschema
-# Enumerable group_by, none?
-# String ord
-# Time to_date, to_time, to_datetime
-require 'active_support'
-require 'active_support/core_ext/date/calculations'
-require 'active_support/core_ext/date_time/conversions'
-require 'active_support/core_ext/enumerable'
-require 'active_support/core_ext/string/conversions'
-require 'active_support/core_ext/string/interpolation'
-require 'active_support/core_ext/time/conversions'
Something went wrong with that request. Please try again.