allow send_file/send_data to skip disposition header, closes #2973 #6078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
options aren't modified inside send_file_headers!
| @@ -127,7 +125,7 @@ def each | |||
| # | |||
| # See +send_file+ for more information on HTTP Content-* headers and caching. | |||
| def send_data(data, options = {}) #:doc: | |||
| send_file_headers! options.dup | |||
There was a problem hiding this comment.
This means we are modifying the original options, no?
There was a problem hiding this comment.
I changed send_file_headers! method and it doesn't modify options now.
josevalim
added a commit
that referenced
this pull request
Apr 30, 2012
allow send_file/send_data to skip disposition header, closes #2973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.