Change unless + else into if + else

[shaliko]

/cc @carlosantoniodasilva, @drogus, @josevalim

[gazay]

I like unless-else in some cases and I don't think that it is necessary to change it here

[rafaelfranca]

We are avoiding this kind of changes in the codebase because they make hander to dig in the git history to track bugs. But they are welcome when you are adding features or solving bugs.

Thanks.

[drogus]

@rafaelfranca I think that code changes to make it easier to understand were usually accepted

[rafaelfranca]

Well, I saw some pull request being closed with the same kind of changes. Some examples 6100, 6000.

And, I don't think that this change make easier to understand, for me is the same thing.

But you can accept it if you want.

[drogus]

@rafaelfranca thanks for references, haven't noticed that before. I agree with that, just was not sure if that's what core team basically recommends

[carlosantoniodasilva]

I have to agree about changing all instances of X for Y, it can really makes things harder later on. But I have to say that in my opinion there wouldn't be any harm in accepting minor readability improvements. We do have limited time, that doesn't mean we can't help someone that tries to contribute, being it with bugs or improvements. Just my 2 cents ;)

[josevalim]

Merged. In any case, the issue with merging these pull requests is that it sends a message to everyone else that we are ok with such changes while I would prefer not to merge them in the first place (different committers may have different opinions).

Again, we have little time and these things do accumulate.