Adds rbx-19mode and jruby-19mode to Travis CI #6264
Conversation
…res on these rubies so that the build status is not interrupted.
|
@parndt Rails VM image does not have Rubinius as far as I remember. That needs to be solved first. |
|
@michaelklishin what about jruby? |
|
Actually, Rubinius and JRuby are there but not aliased exactly the same way as on Ruby images and there's only one mode. It's not a big deal to provision both modes and add aliases and deploy new images but it will take a day or few. |
|
Do we even know if Rails passes on JRuby? Or what the test times are in comparison to 1.9.3? It might be best waiting until we have our new VM architecture up and running as we can then allocate extra VMs with next to no work. |
|
I think we cannot do it for JRuby right now. I faced some issue running it locally for openssl doing bundle install. I think for JRuby we should wait for JRuby 1.7. |
|
We could add one or two Rails bits into an ignore matrix (in case it fails), but step one is to get it passing locally. Feel free to ping me on IRC or in Campfire and we can talk more about this. On 11/05/2012, at 12:16 PM, Arun Agrawal wrote:
|
|
Should I split this up into rbx and jruby separately? |
|
I think the consensus is that Rails core needs to make everything pass on JRuby and Rubinius locally first. |
|
I see your point however with CI and |
|
The main issue right now is that we only have 5 VMs for Rails, adding rbx or jruby will kill the test times. Also, have anyone benchmarked how long rbx or jruby take for rails? On 14/05/2012, at 4:05 AM, Philip Arndt wrote:
|
|
Agree that it will kill test times. |
|
Yes, unfortunately it will always be inconvenient to test extra rubies |
|
In my opinion try to fix them locally first. if there are not much errors then we can think of adding them. Running them as a failures is not a good option. Suggestions ?? |
|
Lets put this on hold until we move to a true VM setup, that way we can allocate more VMs for Rails easily and test times won't explode so much. Until then, why not have someone work on making sure various parts of Rails pass on rbx and jruby and work with the respective teams on making the rails test suite run faster. On 14/05/2012, at 11:25 AM, Philip Arndt wrote:
|
|
A little update for everyone. I am all for adding jruby and rbx to Rails CI, but we need to wait a few more months while we sort out the new VM setup. Has anyone tried running CI tests for jruby or rbx locally and benchmarked how long they take? |
|
We have 3k fails with Rails master and JRuby 1.9 mode. Not sure about the time. I will post here the time from my machine. |
|
Until the new VM setup is ready, why not try to reduce the failures first and maybe we can look at turning on testing for certain parts of Rails (eg. AR and RBX) if they fall within the timeout limits :) |
|
Hey there! @joshk, would this be ready to be merged in, you think? |
|
Sadly no, still working on the infrastructure change, find me in IRC tomorrow and we can talk more about it :) On 12/10/2012, at 12:33 AM, Steve Klabnik wrote:
|
|
Okay :D |
|
We were wondering about times for rbx/jruby to run the test suite. The tests do not run at all on rbx (see the linked bug above) but on Jruby: This is on my year-old MacBook Air. |
|
The rbx 'bug' was not a bug, and while the ActiveModel tests seem to hang on my machine, the suite overall does this: |
|
Ping 4 months stale, what's the status of testing RBX and JRuby? Needs a rebase. |
|
@schneems last time we discussed this, it was 'do they even run?' I cannot currently compile rbx on my machine, so I can't tell you the answer these days :/ |
|
I've deployed Rails apps on JRuby to Heroku before so the tests should pass for that one. What if we just add JRuby today, and RBX another time? |
|
Running on RBX and JRuby is very different to testing on RBX and JRuby. That said, Travis is ready, we just recommend adding component by component, and making sure they pass locally before adding to Travis. :) On 10/03/2013, at 8:05 AM, Richard Schneeman notifications@github.com wrote:
|
|
AR-JDBC is not ready with Rails master right now! |
|
Hey Guys, I have pushed this into a branch to see fails for JRuby. 0f138e02167c Will be working more to fix these tests. @joshk I actually wanted to see fails and I saw travis was not running any rails tests at moment so pushed. |
|
WAT? Travis was not running any Rails builds? What happened? On 12/04/2013, at 2:11 AM, Arun Agrawal notifications@github.com wrote:
|
|
Sorry about my bad english. I meant not at the moment. They are idle :-) |
|
ahhhhhhh, no worries, I was worried for a second there :) On 12/04/2013, at 2:24 AM, Arun Agrawal notifications@github.com wrote:
|
|
Wahooo! Next step: |
|
Done too. |
|
Excellent.. I'll just go ahead and delete my patch branch then |
I've added the rubies to allow_failures so that the build status is not interrupted. I would love to see Rails run CI against these rubies as I believe it will help to fix bugs in the rubies themselves and also Rails.
Both are running only in 1.9 mode as master does not support 1.8 anymore.
Thanks for the time taken to review this.