Remove ActiveSupport::Cache::MemCacheStore #6296
Conversation
|
|
|
Awesome |
| @@ -42,7 +42,8 @@ | |||
| # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new) | |||
|
|
|||
| # Use a different cache store in production. | |||
| # config.cache_store = :mem_cache_store | |||
| # Add dalli to Gemfile for :dalli_store | |||
| # config.cache_store = :dalli_store | |||
There was a problem hiding this comment.
Do you need to set the cache_store to :dalli_store? Why the gem doesn't do that automatically?
There was a problem hiding this comment.
dalli isn't shipped with a railtie to set this config
cc @mperham
There was a problem hiding this comment.
@mperham just sent one ;)
|
-1 on removing the cache store entirely. This will make it really painful to upgrade existing apps. Let's just change the default cache store to Dalli's. We also need to consider how apps should upgrade cache stores. Existing apps are talking to memcache servers full of marshalled data, and reading it with Dalli won't work. You have to change the cache namespace, or clear it entirely. The |
|
Another option: keep the cache store; just switch the internal lib from memcache-client to dalli. |
This addresses rails/rails#6296
|
Could you also update the guide "Caching with Rails: An overview": http://edgeguides.rubyonrails.org/caching_with_rails.html#activesupport-cache-memcachestore |
|
@tkrotoff done, thanks!!! |
memcache-client was deprecated in favor of dalli in 2010, now users should be using dalli_store instead of the old mem_cache_store