Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Removed old API functionality from actionpack text helpers #6370

Merged
merged 0 commits into from

2 participants

@iHiD

I have removed the old API functionality from text helpers as per https://groups.google.com/forum/#!msg/rubyonrails-core/Ta4JrLykxYA/t-pm4DyW_AMJ (cc @rafaelfranca)

I will follow up with depreciation warnings in another pull request on the stable branch.

@rafaelfranca

This pull request cannot be automatically merged. Please rebase it against the master. Also, add a CHANGELOG entry.

@rafaelfranca

As a side note, these API Change was introduced in 10d9fe4, almost 4 years ago, but they was not removed in da84527 because the original author forgot to add a deprecation warning.

@iHiD

Sorry, @rafaelfranca. Does that work now?

@rafaelfranca

Github told me not. Also, now your changes is touching more places.

@iHiD iHiD merged commit 56ba210 into rails:master
@iHiD

Sorry. I'm massively failing here. I've re-done it on a new branch and put a PR at #6371. Does that work any better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 0 deletions.
Something went wrong with that request. Please try again.