Skip to content
This repository

Removed old API functionality from actionpack text helpers #6370

Merged
merged 0 commits into from about 2 years ago

2 participants

Jeremy Walker Rafael Mendonça França
Jeremy Walker
iHiD commented

I have removed the old API functionality from text helpers as per https://groups.google.com/forum/#!msg/rubyonrails-core/Ta4JrLykxYA/t-pm4DyW_AMJ (cc @rafaelfranca)

I will follow up with depreciation warnings in another pull request on the stable branch.

Rafael Mendonça França
Owner

This pull request cannot be automatically merged. Please rebase it against the master. Also, add a CHANGELOG entry.

Rafael Mendonça França
Owner

As a side note, these API Change was introduced in 10d9fe4, almost 4 years ago, but they was not removed in da84527 because the original author forgot to add a deprecation warning.

Jeremy Walker
iHiD commented

Sorry, @rafaelfranca. Does that work now?

Rafael Mendonça França
Owner

Github told me not. Also, now your changes is touching more places.

Jeremy Walker iHiD merged commit 56ba210 into from
Jeremy Walker iHiD closed this
Jeremy Walker
iHiD commented

Sorry. I'm massively failing here. I've re-done it on a new branch and put a PR at #6371. Does that work any better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Sorry, commit information is not available for this pull request.

This page is out of date. Refresh to see the latest.

Showing 0 changed files with 0 additions and 0 deletions. Show diff stats Hide diff stats

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.