Redirect route inspect #6391

Merged
merged 2 commits into from May 18, 2012

Projects

None yet

3 participants

@lukaszx0
Ruby on Rails member

This pull request fixes route inspection for routes that are redirection.

routes.rb:

FooBar::Application.routes.draw do
  match "/foo" => redirect("/bar")
end

rake routes now:

foo  /foo(.:format) :controller#:action"

after patch, fixed:

foo  /foo(.:format)  Redirect (301)
@steveklabnik
Ruby on Rails member

This doesn't merge cleanly, and will need a rebase. And you only pushed in half an hour ago, crazy!

lukaszx0 added some commits May 18, 2012
@lukaszx0 lukaszx0 More DRY route inspect tests 61fc10d
@lukaszx0 lukaszx0 Fix inspecting route redirections, closes #6369
This commit fixes route inspection in `rake routes`

Before:

  foo  /foo(.:format) :controller#:action"

After:

  foo  /foo(.:format)  Redirect (301)
5f7bfb7
@drogus
Ruby on Rails member

RAILS, U SO CRAZY!

@lukaszx0
Ruby on Rails member

Yeah, my bad, had outdated master localy. It should be ok now.

@drogus drogus merged commit 6f0c9cd into rails:master May 18, 2012
@pixeltrix pixeltrix added a commit that referenced this pull request May 19, 2012
@pixeltrix pixeltrix Add CHANGELOG entry for #6369 & #6391 71a83a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment