Fixed typo new_defautls -> new_defaults. #6433

Merged
merged 1 commit into from May 22, 2012

Conversation

Projects
None yet
3 participants
@parndt
Contributor

parndt commented May 22, 2012

Little whitespace fix too.

@drogus

This comment has been minimized.

Show comment Hide comment
@drogus

drogus May 22, 2012

Member

Yes, it definitely needs some tests.

@parndt let me know if you need any help with this or if you won't be able to do it

Member

drogus commented May 22, 2012

Yes, it definitely needs some tests.

@parndt let me know if you need any help with this or if you won't be able to do it

@parndt

This comment has been minimized.

Show comment Hide comment
@parndt

parndt May 22, 2012

Contributor

sure i can look into it

Contributor

parndt commented May 22, 2012

sure i can look into it

@parndt

This comment has been minimized.

Show comment Hide comment
@parndt

parndt May 22, 2012

Contributor

@drogus @kennyj done! I've also improved some of the existing test cases related to this method to match the style of previous tests (assert_equal vs assert)

Contributor

parndt commented May 22, 2012

@drogus @kennyj done! I've also improved some of the existing test cases related to this method to match the style of previous tests (assert_equal vs assert)

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca May 22, 2012

Owner

Could you squash the commits?

Owner

rafaelfranca commented May 22, 2012

Could you squash the commits?

Fixed typo new_defautls -> new_defaults.
* Added tests for 'else' case in ActionView::Helpers::TranslationHelper#wrap_translate_defaults
* Also updated the testing syntax of translation.html_safe? asserts to provide better output upon failure.
@parndt

This comment has been minimized.

Show comment Hide comment
@parndt

parndt May 22, 2012

Contributor

@rafaelfranca gladly; I've just done this. Thanks for the reminder :)

Contributor

parndt commented May 22, 2012

@rafaelfranca gladly; I've just done this. Thanks for the reminder :)

rafaelfranca added a commit that referenced this pull request May 22, 2012

Merge pull request #6433 from parndt/fix_typo
Fixed typo new_defautls -> new_defaults.

@rafaelfranca rafaelfranca merged commit 5089d65 into rails:master May 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment