Responsive guides #6475
Responsive guides #6475
Conversation
|
Awesome, let me play with this a little bit locally before applying. |
|
@joefiorini Isn't it better to use jquery instead of zepto, to support most of mobile browsers? |
|
Yes, I think you're right. My intention was to switch that. I'll push an update tonight. On May 24, 2012, at 4:17 PM, Piotr Sarnackireply@reply.github.com wrote:
|
|
jQuery is now in. Thanks for asking. |
|
To make it easier for people to try it out, I just published my fork of the guides. This is certainly not intended to be anything more than a way for others (and myself) to more easily try to responsive design on different devices. If you're interested check it out http://rails-guides.joefiorini.com. |
|
@joefiorini that looks really cool! :D |
|
Cool! |
|
Great! |
|
So cool. |
|
That's awesome, man! Thanks! |
|
|
|
It'd be nice if the navigation and "Guides Index" link broke to the mobile layout w/ the drop-down menu earlier, as it's not usable at "medium" screen widths. |
|
| @@ -856,7 +856,7 @@ SELECT categories.* FROM categories | |||
| INNER JOIN posts ON posts.category_id = categories.id | |||
| </sql> | |||
|
|
|||
| Or, in English: "return a Category object for all categories with posts". Note that you will see duplicate categories if more than one post has the same category. If you want unique categories, you can use Category.joins(:posts).select("distinct(categories.id)"). | |||
| Or, in English: "return a Category object for all categories with posts". Note that you will see duplicate categories if more than one post has the same category. If you want unique categories, you can use @Category.joins(:posts).select("distinct(categories.id)")@. | |||
There was a problem hiding this comment.
Why is this change part of this PR? Can you make this change in docrails and remove it here?
There was a problem hiding this comment.
I needed to put a tag around it so I could control the text wrapping from CSS to make it fit nicely on a small screen. I would consider this part of the responsive design, not necessarily just a content change.
There was a problem hiding this comment.
We usually recommend code snippets to be formatted in the guides and api docs. That's the reason I asked for the move. But I'm not necessarily bothered by this being here.
|
@vijaydev I ended up squashing it into two commits. Is that good enough? |
|
@joefiorini Squash looks good. |
|
Thanks @vijaydev! Is there anything else I need to do to get this merged in? |
|
Just made a couple changes:
I also plan on adding a medium-display style for the navigation and improving the small-display style. |
|
+1 Example page looks nice: http://rails-guides.joefiorini.com |
|
@morgoth thanks for the feedback, let's aim at merging this in the following days. @joefiorini I have seen in the AS guide code snippets of different sizes in the iPhone, do you know why? Also the guides select says "Active Support ..." instead of "Guides Index", which is what the regular and iPad versions show. Is that intentional? |
ghost
assigned
|
Are you referring to the I18N table? I still need to go through each page and fix instances where pre tags and tables are forcing the width beyond the bounds of the viewport. This causes unwanted horizontal scrolling. As for the Guides Index I set it up to select whichever guide you are currently viewing. I'll change this back to match the behavior of the other formats. Sent from my mobile device On Jul 21, 2012, at 7:09 PM, Xavier Noriareply@reply.github.com wrote:
|
|
Nevermind, I see what you are talking about on the AS guide. I'll look into that when I'm on my computer again. On Jul 21, 2012, at 7:09 PM, Xavier Noriareply@reply.github.com wrote:
|
|
Hey @joefiorini, are we ok with this one, to merge it, or is there anything else missing? Thanks. |
|
@carlosantoniodasilva I still need to make the fix that @fxn recommended. I'll get that in today, and I think we'll be ready to merge then. |
|
Alright, no hurries, just wanted to make sure it was not going to die :). Thanks. |
|
@joefiorini just a ping... any news? |
|
@joefiorini this work is great, love the example page thanks for working on this! Will you be able to make those changes and update this PR soon? |
|
I'm not sure I will, but it's actually a fairly small bug on iOS in tables. On Thu, Oct 4, 2012 at 4:37 PM, Richard Schneeman
|
|
I'd say if it's just a small bug, This will still need a rebase, though. |
|
Rebased, should be ready to go. Can someone merge this in? I'm going to test the small bug I mentioned on iOS 6, if it's still there I'll open an issue for it. Should that be in rails or docrails? |
|
@joefiorini following the thread, I am not sure what is pending as an iOS bug from my two remarks. Which remark is fixed and which isn't? Is http://rails-guides.joefiorini.com up to date? |
|
Actually, nothing anymore. Looks like iOS 6 fixed whatever the problem goes. I think it's good for a first release. On Oct 6, 2012, at 5:49 PM, Xavier Noria notifications@github.com wrote:
|
|
Awesome. I'd merge this if I was allowed. |
|
|
|
@joefiorini but the label is revised? |
|
You mean your comments from 7/21? Those should be fixed now. Sorry for the confusion. |
|
I was referring to an issue with the responsive tables I implemented to fix one of the problems you found. It doesn't appear to be an issue anymore in iOS 6. |
|
Excellent, thanks a lot for this work! |
* .clearfix is overridden. * .clear is not currently used. * #extraCol is not currently used. * table th, table td are overridden. Merged them. * Removed needless comment lines which are added on rails#6475
I started implementing a responsive design for the Rails guides. I've only tested it on Apple laptops & portable devices, but I wanted to get feedback before going much further. What further do we need to do to pull this in and get it deployed?
(Note: I originally requested this on lifo/docrails and was asked to send it here instead)