Skip to content
This repository

Remove Unnecessary Test from route_inspect_test #6481

Merged
merged 1 commit into from almost 2 years ago

2 participants

Richard Schneeman Rafael Mendonça França
Richard Schneeman
Collaborator

RoutePresenter has been removed, this test is not needed. Related conversation:

c3e3102#commitcomment-1374990

~/documents/projects/rails/railties (schneems/sextant-routes)   
→ bundle exec rake test:regular TEST=test/application/route_inspect_test.rb 
/Users/schneems/.rvm/rubies/ruby-1.9.3-rc1/bin/ruby -w -I"lib:test:/Users/schneems/Documents/projects/rails/railties/../activesupport/lib" -I"/Users/schneems/.rvm/gems/ruby-1.9.3-rc1@railscore/gems/rake-0.9.2.2/lib" "/Users/schneems/.rvm/gems/ruby-1.9.3-rc1@railscore/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb" "test/application/route_inspect_test.rb" 
Run options: --seed 18733

# Running tests:

..............

Finished tests in 0.223237s, 62.7136 tests/s, 85.1113 assertions/s.

14 tests, 19 assertions, 0 failures, 0 errors, 0 skips

Fixes the tests for route_inspect_test

Rafael Mendonça França rafaelfranca merged commit 641ab7c into from May 24, 2012
Rafael Mendonça França rafaelfranca closed this May 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 24, 2012
Richard Schneeman remove unnecessary test from route_inspect_test 4459125
This page is out of date. Refresh to see the latest.
9  railties/test/application/route_inspect_test.rb
@@ -164,14 +164,5 @@ def test_redirect
164 164
       assert_equal "   bar GET /bar(.:format)    redirect(307, path: /foo/bar)", output[1]
165 165
       assert_equal "foobar GET /foobar(.:format) redirect(301)", output[2]
166 166
     end
167  
-
168  
-    def test_presenter
169  
-      output = draw do
170  
-        get "/foo"    => redirect("/foo/bar"), :constraints => { :subdomain => "admin" }
171  
-        get "/bar"    => redirect(path: "/foo/bar", status: 307)
172  
-        get "/foobar" => redirect{ "/foo/bar" }
173  
-      end
174  
-      assert_equal output.join("\n"), Rails::Application::RoutePresenter.display_routes(@set.routes)
175  
-    end
176 167
   end
177 168
 end
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.