Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRecord::Calculations#pluck accepts multiple columns #6500

wants to merge 3 commits into from


Copy link

Rails currently supports this:
Person.pluck(:id) # SELECT FROM people

I added two possibilities:
Person.pluck(:id) # SELECT FROM people
Person.pluck([:id, :name]) # SELECT, FROM people
Person.pluck(:id, :name) # SELECT, FROM people

Because I made some stupid mistakes while updating my own fork of rails/rails this is a new fork and a follow up of the discussion located here: #5472

Copy link

Mentioning #5472 so that GitHub links them.

column_name.collect{|c| attributes[c.to_s]}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Columns need to be typecasted in both scenarios, otherwise pluck would work differently when using 1 and more columns.

Copy link

I think we should probably have this feature as people keep asking about it. However I think we should decide between Post.pluck([:a, :b]) and Post.pluck(:a, :b) and just support one of them. I think probably the latter.

Copy link

@carlos, you were right with your comment my mistakes. Just fixed and pushed it!

@jon In my previous pull request, several people liked it (see #5472). So IMO that's not the problem. But why do you want to support just one of the possibilities of Post.pluck([:a, :b]) and Post.pluck(:a, :b) and not both?

Copy link

@jeroeningen I've pulled your changes and modified as per @jonleighton comments: d59b2ab. Thanks for your work on that :).

Copy link

How about if pluck would also account for the select arguments? So[:id, :name]).pluck would project id and name.

Copy link

@RKushnir we've just merged a change that will ignore the select values in 3a33572. If you think it can be improved, please feel free to open a new topic in the core mailing list. Thanks.

sgerrand pushed a commit to sgerrand/rails that referenced this pull request Nov 2, 2013
Ensure it works with mix of symbols and strings, and with a select
clause possibly containing more than one column.

Also remove support for pluck with an array of columns, in favor of
passing the list of attributes:

    Model.pluck(:a, :b)

See comments: rails#6500 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants