Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

encoding aware removal. Not required in master! #6529

Closed
wants to merge 1 commit into from

2 participants

@raysrashmi

removed last instances of encoding aware from master.

@rafaelfranca

Thank you for the pull request but encoding_aware? will not remove in the 4.0 version since it was not deprecated in 3-2-stable. We'll leave it until the 4.1 release.

@raysrashmi

ahh thanks for review. Can we remove that test for checking aware thing? Or we will remove this together ?

@rafaelfranca

We will remove together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 29, 2012
  1. @raysrashmi
This page is out of date. Refresh to see the latest.
View
8 activesupport/lib/active_support/core_ext/string/encoding.rb
@@ -1,8 +0,0 @@
-require 'active_support/deprecation'
-
-class String
- def encoding_aware?
- ActiveSupport::Deprecation.warn 'String#encoding_aware? is deprecated', caller
- true
- end
-end
View
6 activesupport/test/core_ext/string_ext_test.rb
@@ -485,12 +485,6 @@ def to_s
assert_equal 'foo'.to_yaml, 'foo'.html_safe.to_yaml(:foo => 1)
end
- test 'knows whether it is encoding aware' do
- assert_deprecated do
- assert 'ruby'.encoding_aware?
- end
- end
-
test "call to_param returns a normal string" do
string = @string.html_safe
assert string.html_safe?
Something went wrong with that request. Please try again.