Exceptions like Interrupt should not be rescued in tests. #6531

Merged
merged 1 commit into from May 29, 2012

3 participants

@floehopper

This is a back-port of rails/rails#6525. See the commit notes there for
details.

@floehopper floehopper Exceptions like Interrupt should not be rescued in tests.
This is a back-port of rails/rails#6525. See the commit notes there for
details.
0813b45
@rafaelfranca
Ruby on Rails member

Why the code is different to #6525? I think that we should not use MiniTest::Unit::TestCase::PASSTHROUGH_EXCEPTIONS

@floehopper

I was trying to make the code as similar as possible to that which was already there. In ForClassicTestUnit this is the style that is used. In master this module no longer exists. I'm happy to change this pull request to match master if you prefer.

@rafaelfranca
Ruby on Rails member

Ok. Thank you for the explanation. I'll merge it now.

@rafaelfranca rafaelfranca merged commit 12e5c72 into rails:3-2-stable May 29, 2012
@pixeltrix
Ruby on Rails member

Also 3-2-stable and 3-1-stable still support 1.8.7 so it should also fix the problem for Test::Unit

@rafaelfranca
Ruby on Rails member

I think it is fixed as @floehopper pointed in their last comment.

@pixeltrix
Ruby on Rails member

Yep, just spotted that - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment