Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Exceptions like Interrupt should not be rescued in tests. #6531

Merged
merged 1 commit into from May 29, 2012

Conversation

Projects
None yet
3 participants
Contributor

floehopper commented May 29, 2012

This is a back-port of rails/rails#6525. See the commit notes there for
details.

Exceptions like Interrupt should not be rescued in tests.
This is a back-port of rails/rails#6525. See the commit notes there for
details.
Owner

rafaelfranca commented May 29, 2012

Why the code is different to #6525? I think that we should not use MiniTest::Unit::TestCase::PASSTHROUGH_EXCEPTIONS

Contributor

floehopper commented May 29, 2012

I was trying to make the code as similar as possible to that which was already there. In ForClassicTestUnit this is the style that is used. In master this module no longer exists. I'm happy to change this pull request to match master if you prefer.

Owner

rafaelfranca commented May 29, 2012

Ok. Thank you for the explanation. I'll merge it now.

rafaelfranca added a commit that referenced this pull request May 29, 2012

Merge pull request #6531 from freerange/3-2-stable-minitest-passthrou…
…gh-exceptions

Exceptions like Interrupt should not be rescued in tests.

@rafaelfranca rafaelfranca merged commit 12e5c72 into rails:3-2-stable May 29, 2012

Owner

pixeltrix commented May 29, 2012

Also 3-2-stable and 3-1-stable still support 1.8.7 so it should also fix the problem for Test::Unit

Owner

rafaelfranca commented May 29, 2012

I think it is fixed as @floehopper pointed in their last comment.

Owner

pixeltrix commented May 29, 2012

Yep, just spotted that - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment