Skip to content
This repository

3-2-stable Changed symbol platform to platforms for the commented out call to gem 'therubyracer'. #6562

Merged
merged 1 commit into from almost 2 years ago

2 participants

Rafael Mendonça França martinoconnor
Deleted user
ghost commented May 30, 2012

The content you are editing has changed. Reload the page and try again.

Dependency.rb expects the symbol to be named :platforms as opposed to platform. RubyMine's inspections indicate that the symbol should be named :platforms.
Updating tests.

Sending Request…

Attach images by dragging & dropping or selecting them. Octocat-spinner-32 Uploading your images… Unfortunately, we don't support that file type. Try again with a PNG, GIF, or JPG. Yowza, that's a big file. Try again with an image file smaller than 10MB. This browser doesn't support image attachments. We recommend updating to the latest Internet Explorer, Google Chrome, or Firefox. Something went really wrong, and we can't process that image. Try again.

martinoconnor Changed symbol platform to platforms for the commented out call to ge…
…m 'therubyracer'.

Dependency.rb expects the symbol to be named :platforms as opposed to platform. RubyMine's inspections indicate that the symbol should be named :platforms.
Updating tests.
9bbdceb
Rafael Mendonça França rafaelfranca merged commit f8f6ad6 into from May 30, 2012
Rafael Mendonça França rafaelfranca closed this May 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 30, 2012
martinoconnor Changed symbol platform to platforms for the commented out call to ge…
…m 'therubyracer'.

Dependency.rb expects the symbol to be named :platforms as opposed to platform. RubyMine's inspections indicate that the symbol should be named :platforms.
Updating tests.
9bbdceb
This page is out of date. Refresh to see the latest.
2  railties/lib/rails/generators/app_base.rb
@@ -234,7 +234,7 @@ def javascript_runtime_gemfile_entry
234 234
         if defined?(JRUBY_VERSION)
235 235
           "gem 'therubyrhino'\n"
236 236
         else
237  
-          "# gem 'therubyracer', :platform => :ruby\n"
  237
+          "# gem 'therubyracer', :platforms => :ruby\n"
238 238
         end
239 239
       end
240 240
 
2  railties/test/generators/app_generator_test.rb
@@ -253,7 +253,7 @@ def test_inclusion_of_javascript_runtime
253 253
     if defined?(JRUBY_VERSION)
254 254
       assert_file "Gemfile", /gem\s+["']therubyrhino["']$/
255 255
     else
256  
-      assert_file "Gemfile", /# gem\s+["']therubyracer["']+, :platform => :ruby$/
  256
+      assert_file "Gemfile", /# gem\s+["']therubyracer["']+, :platforms => :ruby$/
257 257
     end
258 258
   end
259 259
 
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.