Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Notify A User they Have Pending Migrations #6665
After a member of a team adds commits new code and a migration, other developers might not notice the migration and will get
I've seen this behavior confuse beginner rails developers and seasoned devs. Usually they are capable of figuring out they need to run migrations, but the error is misleading, frustrating, and potentially time consuming.
raise error for pending migration
Can be configured by setting
This check is turned off in production.
The check can be disabled by setting
This PR picks up where #4165 left off.
Railties Tests are green: https://gist.github.com/2885779
AR Tests are green: https://gist.github.com/2885796
I am still uneasy about some of these changes. The fact we are white-listing many rake tasks makes my spider-sense go crazy. Here is what I propose:
Thanks a lot for your work!
Made the suggested modifications. Middleware only loads when the config is set to
Let me know what you think when you get a chance. Have a happy weekend.
added a commit
this pull request
Jun 10, 2012
referenced this pull request
Jun 10, 2012
It's hard to understate how impactful I believe this seemingly small feature will be. Both seasoned devs and beginners routinely get caught pants down by the problem it solves.
Congratulations to @schneems and everyone involved for pushing this through.
Not sure it's worth opening a new issue for, but this is what I see on the latest rails/rails in development:
Seems like ENV['RAILS_ENV'] isn't defined.