Bugfix: Namespace collision with test-unit-activesupport 1.0.0 #6693

Merged
merged 1 commit into from Jun 10, 2012

Projects

None yet

2 participants

@jkraemer

Problem

Unable to run functional / integration tests with Rails 2.3.5 and Test-Unit 2.5 due to

gems/activesupport-3.2.5/lib/active_support/testing/deprecation.rb:48:in `message': uninitialized constant Test::Unit::ActiveSupport::Deprecation (NameError)
    from gems/test-unit-2.4.9/lib/test/unit/ui/console/testrunner.rb:182:in `output_fault_in_detail'

Reason and Fix

active_support/testing/deprecation.rb surrounds Test::Unit::Error#message with a call to ActiveSupport::Deprecation.silence, however Test::Unit now declares it's own Test::Unit::ActiveSupport module, which of course lacks the Deprecation module.

Prepending the call with :: fixes the problem.

@josevalim josevalim merged commit 6cc941d into rails:3-2-stable Jun 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment