Remove extra test case. #6784

Merged
merged 1 commit into from Jun 19, 2012

2 participants

@mikegehard

A very small change that removes what I consider a duplicate test.

Comments welcome.

@carlosantoniodasilva carlosantoniodasilva commented on an outdated diff Jun 19, 2012
activesupport/test/clean_backtrace_test.rb
@@ -6,8 +6,10 @@ def setup
@bc.add_filter { |line| line.gsub("/my/prefix", '') }
end
- test "backtrace should not contain prefix when it has been filtered out" do
- assert_equal "/my/class.rb", @bc.clean([ "/my/prefix/my/class.rb" ]).first
+ test "backtrace should filter all lines in a backtrace" do
@carlosantoniodasilva
Ruby on Rails member

Although the tests have similar assertions, the description is quite different. Perhaps we could use something like:

"backtrace should filter all lines in a backtrace removing prefixes"

wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mikegehard

Works for me. Thanks for the feedback.

@carlosantoniodasilva
Ruby on Rails member

Thanks. I'll have to ask you to squash the commits into one, and push force to your branch, so we can merge.

@mikegehard mikegehard Remove extra test case.
Make the test description better reflect what is happening
db03f13
@mikegehard

All yours. Thanks.

@carlosantoniodasilva carlosantoniodasilva merged commit 82cf95c into rails:master Jun 19, 2012
@carlosantoniodasilva
Ruby on Rails member

Great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment