AS::Callbacks: deprecate monkey patch code #6859

Merged
merged 1 commit into from Jun 26, 2012

Conversation

Projects
None yet
3 participants
Contributor

bogdan commented Jun 26, 2012

Deprecate usage of filter object with #before and #after
methods as around callback.

There is some code monkey patches objects passed to set_callback method. This should never happen.
The only one usage of this is found in ActionController::Caching::Sweeper which is easy to fix.

@bogdan bogdan AS::Callbacks: deprecate monkey patch code
Deprecate usage of filter object with #before and #after
methods as around callback
88230b7

josevalim merged commit cfd21f0 into rails:master Jun 26, 2012

@spastorino spastorino commented on the diff Jun 26, 2012

actionpack/action_pack_url_generator.rb
@@ -0,0 +1 @@
+/home/bogdan/makabu/my/benchmarks/action_pack_url_generator.rb
@spastorino

spastorino Jun 26, 2012

Owner

not sure what was the intention with this symlink, I guess you committed by accident

@bogdan

bogdan Jun 26, 2012

Contributor

Yes, sorry for that. There was only one line in diff and I missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment