update performance test template to use test method #6991

Merged
merged 1 commit into from Jul 24, 2012

Conversation

Projects
None yet
4 participants
Contributor

frodsan commented Jul 6, 2012

No description provided.

@tenderlove tenderlove and 1 other commented on an outdated diff Jul 6, 2012

guides/source/performance_testing.textile
@@ -24,7 +24,7 @@ require 'rails/performance_test_help'
# Profiling results for each test method are written to tmp/performance.
class BrowsingTest < ActionDispatch::PerformanceTest
- def test_homepage
+ test "homepage" do
@tenderlove

tenderlove Jul 6, 2012

Owner

Renaming these tests doesn't add anything. Can you please revert these? I'd like the pull request to have one topic, which is "updating the documentation".

Thanks.

@frodsan

frodsan Jul 6, 2012

Contributor

done.

Contributor

frodsan commented Jul 10, 2012

any news? This is a small change.

Contributor

frodsan commented Jul 10, 2012

@carlosantoniodasilva hey mate, the label of this pr says "docs" but i'm just updating the performance tests templates.

@rafaelfranca rafaelfranca added a commit that referenced this pull request Jul 24, 2012

@rafaelfranca rafaelfranca Merge pull request #6991 from frodsan/performance_test_generator
update performance test template to use test method
66b859b

@rafaelfranca rafaelfranca merged commit 66b859b into rails:master Jul 24, 2012

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment