Back-port #6874 to 3.2: psql adapter should rename a default pk sequence during rename_table #7031

Merged
merged 1 commit into from Jul 11, 2012

Conversation

Projects
None yet
2 participants
Contributor

robbkidd commented Jul 11, 2012

Requestng #6874 be back-ported to 3.2.

Discussion there had two of us (@steveklabnik and myself) thinking this may be a bug fix rather than new behavior.

Test was written in the style of the existing 3.2 rename_table tests. I like the ones in master much more.

Member

drogus commented Jul 11, 2012

Yup, I would also consider it a bug. If I change name to something completely different, I would expect that sequence will also be changed.

drogus added a commit that referenced this pull request Jul 11, 2012

Merge pull request #7031 from robbkidd/rename_sequences_too_backport_…
…to_3-2

Back-port #6874 to 3.2: psql adapter should rename a default pk sequence during rename_table

@drogus drogus merged commit e72d876 into rails:3-2-stable Jul 11, 2012

robbkidd pushed a commit to poboy/activerecord-jdbc-adapter that referenced this pull request Jul 15, 2012

Robb Kidd
Update PG: rename sequence during table rename
This keeps the ARJDBC implementation behavior in sync with
Rails' Active Record following the acceptance of rails/rails#7031

@robbkidd robbkidd referenced this pull request in jruby/activerecord-jdbc-adapter Jul 15, 2012

Merged

Update PG: rename sequence during table rename #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment