Often I need to build form(sign in or feedback form) with inputs which dont have value. But also I need specify custom style to it. So I use text_field_tag method in which second argument value and third options. But I dont need set value, so I put blank string or nil. As we know sending nil to method not good ruby practice, so I change it to more flexible way
text_field_tag 'field', :class => 'custom css'
# is equal to
text_field_tag 'field', nil, :class => 'custom css'
Also changed password field, email field, textarea and etc
So I normally have this issue too, but removing the nils in commits becomes an error.
make argument optional in form_tag_helpers
put changes into single commit
I didn't like this change. Right now the API is very clear and with this change it will be more confusing.
Agreed with @rafaelfranca
maybe next time
@jalkoby I agree with you about the nil being a smell but right now, changing the API will confuse the people. I'm in favor of a better API to views helpers but we will need a lot of discussion.
Maybe in a next mayor release...
Thank you so much for your contribution. We really appreciate.