AR::Integration must be included after AM::Conversion #7080

Merged
merged 1 commit into from Jul 17, 2012

Conversation

Projects
None yet
3 participants
Contributor

jfirebaugh commented Jul 17, 2012

Integration's definition of #to_param must override Conversion's. Otherwise,
there is a regression from 3.1 in the behavior of a non-persisted AR::Base
instance which nevertheless has an id.

On master, a similar change is needed -- or we can remove AR::Integration#to_param
and accept the behavioral change, or we can remove AR::Integration#to_param and
change AM::Conversion#to_param to have the AR::Integration behavior.

@jfirebaugh jfirebaugh AR::Integration must be included after AM::Conversion
Integration's definition of #to_param must override
Conversion's. Otherwise, there is a regression from
3.1 in the behavior of a non-persisted AR::Base instance
which nevertheless has an id.
9b5309f
Owner

rafaelfranca commented Jul 17, 2012

Seems fine. cc @jonleighton

Member

jonleighton commented Jul 17, 2012

Seems fine, but please also open a PR against master for the same change. I will then merge them both.

Contributor

jfirebaugh commented Jul 17, 2012

Done -- #7081.

@jonleighton jonleighton added a commit that referenced this pull request Jul 17, 2012

@jonleighton jonleighton Merge pull request #7080 from jfirebaugh/to_param_regression
AR::Integration must be included after AM::Conversion
827f369

@jonleighton jonleighton merged commit 827f369 into rails:3-2-stable Jul 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment