Enable to enforce Postgresql Adapter query search_path from database every time. #7083

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants

timnew commented Jul 18, 2012

Add always_query_search_path attribute to PostgresqlAdapter.
By setting the attribute to true to enforce adapter query search_path from database every time rather than return the cached value.

Owner

rafaelfranca commented Jul 18, 2012

This pull request have a commit that should not be here.

timnew commented Jul 20, 2012

Can anybody who is kindly to tell me how to remove the commit from the pull request?

Add attribute always_query_search_path to PostgresqlAdapter
Set attribute to true to force the adapter to get search path by querying database every time rather return the cached value.
Used in case that search_path set with raw sql rather than method call.

timnew commented Aug 29, 2012

Thanks @LTe
I'm not quite understand, my local copy is that I forked from origin.
But when I send the pull request, one more commit appears in my pull request, does it mean that someone remove a commit on the origin? Or I cannot understand where the commit is coming from.

Member

steveklabnik commented Aug 29, 2012

@timnew

If you change the commits that are on your master branch on your fork, this pull request gets updated. So if you use git rebase and force push to the branch again, it will update the request.

It appears that there's only one commit on this request now.

timnew commented Aug 31, 2012

Hi @steveklabnik
I have updated this pull request according to @LTe 's suggestion, I'm curious where the additional commit coming from. :)

Member

steveklabnik commented Aug 31, 2012

I don't know why it was before, but it's not there now.

Member

steveklabnik commented Nov 17, 2012

This will need rebased again if it's ever to be included.

Contributor

stouset commented Mar 27, 2013

What problem are you trying to solve?

This seems like a heavy-handed approach that could be solved better a different way. With this patch, you'll at a minimum issue a second query to the database for every single query your app executes (just due to the query cache alone).

Member

jonleighton commented Apr 5, 2013

Yes, I don't really understand this. I suggest discussing your problem on the mailing list first, as this is not going to be merged as-is.

@jonleighton jonleighton closed this Apr 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment