New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new irregular inflection criterion -> criteria #7086

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@filipeamoreira
Copy link
Contributor

filipeamoreira commented Jul 18, 2012

According to http://dictionary.reference.com/browse/criterion the
correct singular form of 'criteria' is 'criterion' and not 'criterium'
which is being returned by ActiveSupport right now.

Add new irregular inflection criterion -> criteria
According to http://dictionary.reference.com/browse/criterion the
correct singular form of 'criteria' is 'criterion' and not 'criterium'
which is being returned by ActiveSupport right now.
@dmathieu

This comment has been minimized.

Copy link
Contributor

dmathieu commented Jul 18, 2012

Thanks for your pull request. But inflections are currently frozen as it can easily break existing applications.

@josevalim

This comment has been minimized.

Copy link
Contributor

josevalim commented Jul 18, 2012

Luckily, you can easily add the inflection to your apps!

@josevalim josevalim closed this Jul 18, 2012

@filipeamoreira

This comment has been minimized.

Copy link
Contributor Author

filipeamoreira commented Jul 18, 2012

It makes sense to freeze inflections and I have already added to my app.

Thank you guys and keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment