Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Corrected small bug that puts the message in place of the progname #7091

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

TaggedLogging places the message part in the progname. This does not cause an issue with the standard Logger. However, with Loggers like Syslogger the end message looks like:

My message: [0123] My message

This is a simple fixe that solves the issue.

Contributor

acapilleri commented Jul 18, 2012

any test for this?

No sorry, as I said, the bug does only show when used in conjunction with a logger that actually supports progname. Which is not the case of the std logger. If I did not break the current tests, it should be fine. I have a monkey patch doing the same in my environment and it works.

Not having a test means we cannot guarantee that fixing it now, won't break in future releases. Can you try adding a test with a bare class that simulates a logger with progname? Just to ensure that calling such methods would work when progname exists.

Also, please send a pull request to master first, we don't usually merge things first in 3-2 branch, but backport if necessary. Thanks!

I understand, if I have time available I will do but I cannot promise anything. Also, it seems the whole class has been refactored in master which complicates the matter even further.

Ok, please let us know when you have any news. Unfortunately we're not merging things to 3-2 unless they've already been changed/fixed on master. Thanks!

Closing, please let us know if you have any news, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment