Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix build. There is journey-1.0.4 on the 1-0-stable branch. #7137

Merged
merged 1 commit into from Jul 23, 2012

Conversation

Projects
None yet
4 participants
Contributor

kennyj commented Jul 23, 2012

Now, we can't success bundle update, because we can't find journey-1.0.4.

According to https://github.com/rails/journey, there is 1.0.4 on the 1-0-stable branch.
So I added a :branch option.

Contributor

kennyj commented Jul 23, 2012

related to 4d7a102.

Owner

spastorino commented Jul 23, 2012

Why should Rails master follow a journey stable branch instead of following master?

Contributor

kennyj commented Jul 23, 2012

I guess journey master's gemspec version is 1.0.1.20120208102204.
https://github.com/rails/journey/blob/master/journey.gemspec#L5 .

Should we fix gemspec ?

Owner

rafaelfranca commented Jul 23, 2012

@kennyj yes.

Contributor

kennyj commented Jul 23, 2012

I don't know journey's versioning rule.
Is rails 3-2-stable corresponded to journey 1-0-stable ?
what does journey version correspond to rails 4-0 ?

Owner

rafaelfranca commented Jul 23, 2012

@kennyj can you check with @tenderlove?

Contributor

kennyj commented Jul 23, 2012

Roger. When seeing @tenderlove, I'll check with him.

Contributor

kennyj commented Jul 23, 2012

thanks @rafaelfranca for bumping. I fixed this PR.

rafaelfranca added a commit that referenced this pull request Jul 23, 2012

Merge pull request #7137 from kennyj/fix_installing_problem_journey
Fix build. There is journey-1.0.4 on the 1-0-stable branch.

@rafaelfranca rafaelfranca merged commit 998189a into rails:master Jul 23, 2012

Owner

pixeltrix commented Jul 23, 2012

@spastorino @rafaelfranca sorry for breaking the build - I didn't spot it as I was dealing with problems caused by the Zerigo outage.

Owner

rafaelfranca commented Jul 23, 2012

@pixeltrix no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment