New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the flush parameter with a Hash. #7150

Merged
merged 1 commit into from Jul 24, 2012

Conversation

Projects
None yet
4 participants
@lucasmazza
Member

lucasmazza commented Jul 24, 2012

No description provided.

rafaelfranca added a commit that referenced this pull request Jul 24, 2012

Merge pull request #7150 from lucasmazza/flush_option
Replace the flush parameter with a Hash.

@rafaelfranca rafaelfranca merged commit d7856d3 into rails:master Jul 24, 2012

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment

❤️

@betelgeuse

This comment has been minimized.

Show comment
Hide comment
@betelgeuse

betelgeuse Jul 28, 2012

flush to me doesn't seem like explanatory naming. flush on buffers means emptying the buffer to the stream so my first thought when reading such code would be that it has something to do with streaming. Why not call it replace instead?

//cc @rafaelfranca

flush to me doesn't seem like explanatory naming. flush on buffers means emptying the buffer to the stream so my first thought when reading such code would be that it has something to do with streaming. Why not call it replace instead?

//cc @rafaelfranca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment