Skip to content

Replace the flush parameter with a Hash. #7150

Merged
merged 1 commit into from Jul 24, 2012

4 participants

@lucasmazza
Ruby on Rails member

No description provided.

@rafaelfranca rafaelfranca merged commit d7856d3 into rails:master Jul 24, 2012
@carlosantoniodasilva
Ruby on Rails member

:heart:

@betelgeuse

flush to me doesn't seem like explanatory naming. flush on buffers means emptying the buffer to the stream so my first thought when reading such code would be that it has something to do with streaming. Why not call it replace instead?

//cc @rafaelfranca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.