remove duplicate build runs in travis #7151

Merged
merged 1 commit into from Jul 25, 2012

Projects

None yet

2 participants

@graceliu

These extra runs were used to test identity map and not fully removed when the feature was removed.

When identity map was removed, ci/travis.rb was updated to remove the line in the if build.activerecord? clause that sets the :identity_map build option to true. However, the entire if build.activerecord? clause needs to be removed to remove the extra build.run! inside the clause.

Currently, for each database, activerecord tests are run 4 times, twice not in isolation, and twice in isolation. They only need to be run twice, once not in isolation, and once in isolation.

To validate the fix, I have run ci/travis.rb against all the variations of the GEM environment variable as specified in .travis.yml. All tests ran successfully and there were no duplicate runs. I ran the tests using ruby 1.9.3 in a vagrant box provisioned based on the same travis cookbook recipes that the travis standard worker box uses.

Please let me know any more work I need to do for this fix.

@graceliu graceliu remove duplicate build runs in travis. These extra runs were used to
test identity map and not fully removed when the feature was removed.
0c1c0c6
@carlosantoniodasilva

Great catch, thank you for that! 😄

@carlosantoniodasilva carlosantoniodasilva merged commit c324f42 into rails:master Jul 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment